Make changes as per feedback from Pierre

airflow/api_fastapi/common/types.py

@@ -16,7 +16,7 @@
 # under the License.
 from __future__ import annotations
 
-from datetime import datetime, timedelta
+from datetime import timedelta
 from enum import Enum
 from typing import Annotated
 
@@ -66,20 +66,6 @@ class TimeDelta(BaseModel):
 TimeDeltaWithValidation = Annotated[TimeDelta, BeforeValidator(_validate_timedelta_field)]
 
 
-def _validate_nonnaive_datetime_field(dt: datetime | None) -> datetime | None:
-    """Validate and return the datetime field."""
-    if dt is None:
-        return None
-    if isinstance(dt, str):
-        dt = datetime.fromisoformat(dt)
-    if not dt.tzinfo:
-        raise ValueError("Invalid datetime format, Naive datetime is disallowed")
-    return dt
-
-
-DatetimeWithNonNaiveValidation = Annotated[datetime, BeforeValidator(_validate_nonnaive_datetime_field)]
-
-
 class Mimetype(str, Enum):
     """Mimetype for the `Content-Type` header."""
 

airflow/api_fastapi/core_api/datamodels/task_instances.py

@@ -20,7 +20,6 @@
 from typing import Annotated, Any
 
 from pydantic import (
-    AliasChoices,
     AliasPath,
     AwareDatetime,
     BaseModel,
@@ -32,7 +31,6 @@
     model_validator,
 )
 
-from airflow.api_fastapi.common.types import DatetimeWithNonNaiveValidation
 from airflow.api_fastapi.core_api.datamodels.job import JobResponse
 from airflow.api_fastapi.core_api.datamodels.trigger import TriggerResponse
 from airflow.utils.state import TaskInstanceState
@@ -160,8 +158,8 @@ class ClearTaskInstancesBody(BaseModel):
     """Request body for Clear Task Instances endpoint."""
 
     dry_run: bool = True
-    start_date: DatetimeWithNonNaiveValidation | None = None
-    end_date: DatetimeWithNonNaiveValidation | None = None
+    start_date: AwareDatetime | None = None
+    end_date: AwareDatetime | None = None
     only_failed: bool = True
     only_running: bool = False
     reset_dag_runs: bool = False
@@ -196,7 +194,7 @@ class TaskInstanceReferenceResponse(BaseModel):
     """Task Instance Reference serializer for responses."""
 
     task_id: str
-    dag_run_id: str = Field(validation_alias=AliasChoices("run_id"))
+    dag_run_id: str = Field(validation_alias="run_id")
     dag_id: str
     logical_date: datetime
 

airflow/api_fastapi/core_api/routes/public/task_instances.py

@@ -268,7 +268,7 @@ def get_mapped_task_instance(
 
 
 @task_instances_router.get(
-    task_instances_prefix + "",
+    task_instances_prefix,
     responses=create_openapi_http_exception_doc([status.HTTP_404_NOT_FOUND]),
 )
 def get_task_instances(
@@ -541,15 +541,15 @@ def post_clear_task_instances(
 
     task_instances = dag.clear(
         dry_run=True,
-        task_ids=body.task_ids,
+        task_ids=task_ids,
         dag_bag=request.app.state.dag_bag,
         **body.model_dump(
-            include=[  # type: ignore[arg-type]
+            include={
                 "start_date",
                 "end_date",
                 "only_failed",
                 "only_running",
-            ]
+            }
         ),
     )
 

tests/api_fastapi/core_api/routes/public/test_task_instances.py

@@ -24,11 +24,13 @@
 
 import pendulum
 import pytest
+import sqlalchemy
 
 from airflow.jobs.job import Job
 from airflow.jobs.triggerer_job_runner import TriggererJobRunner
 from airflow.models import DagRun, TaskInstance
 from airflow.models.baseoperator import BaseOperator
+from airflow.models.dag import DAG
 from airflow.models.dagbag import DagBag
 from airflow.models.renderedtifields import RenderedTaskInstanceFields as RTIF
 from airflow.models.taskinstancehistory import TaskInstanceHistory
@@ -1836,21 +1838,36 @@ def test_should_respond_200(
         assert response.status_code == 200
         assert len(response.json()["task_instances"]) == expected_ti
 
-    def test_clear_taskinstance_is_called_with_queued_dr_state(self, test_client, session):
+    @mock.patch("airflow.api_fastapi.core_api.routes.public.task_instances.clear_task_instances")
+    def test_clear_taskinstance_is_called_with_queued_dr_state(self, mock_clearti, test_client, session):
         """Test that if reset_dag_runs is True, then clear_task_instances is called with State.QUEUED"""
         self.create_task_instances(session)
         dag_id = "example_python_operator"
         payload = {"reset_dag_runs": True, "dry_run": False}
         self.dagbag.sync_to_db()
-        with mock.patch(
-            "airflow.api_fastapi.core_api.routes.public.task_instances.clear_task_instances",
-        ) as mp:
-            response = test_client.post(
-                f"/public/dags/{dag_id}/clearTaskInstances",
-                json=payload,
-            )
-            assert response.status_code == 200
-            mp.assert_called_once()
+        response = test_client.post(
+            f"/public/dags/{dag_id}/clearTaskInstances",
+            json=payload,
+        )
+        assert response.status_code == 200
+
+        # We check args individually instead of direct matching using
+        # assert_called_once_with(), because the session objects don't match
+        # and can't be skipped using mock.ANY.
+        mock_clearti.assert_called_once()
+        args, kwargs = mock_clearti.call_args
+        assert len(args) == 4
+        assert len(kwargs) == 0
+        # 1st argument
+        assert args[0] == []
+        # 2nd argument
+        assert args[1] is not None
+        assert isinstance(args[1], sqlalchemy.orm.session.Session)
+        # 3rd argument
+        assert args[2].dag_id, dag_id
+        assert isinstance(args[2], DAG)
+        # 4th argument
+        assert args[3] == DagRunState.QUEUED
 
     def test_clear_taskinstance_is_called_with_invalid_task_ids(self, test_client, session):
         """Test that dagrun is running when invalid task_ids are passed to clearTaskInstances API."""
@@ -2235,11 +2252,10 @@ def test_should_respond_404_for_nonexistent_dagrun_id(self, test_client, session
                 {
                     "detail": [
                         {
-                            "type": "value_error",
+                            "type": "timezone_aware",
                             "loc": ["body", "end_date"],
-                            "msg": "Value error, Invalid datetime format, Naive datetime is disallowed",
+                            "msg": "Input should have timezone info",
                             "input": "2020-11-10T12:42:39.442973",
-                            "ctx": {"error": {}},
                         }
                     ]
                 },
@@ -2249,11 +2265,11 @@ def test_should_respond_404_for_nonexistent_dagrun_id(self, test_client, session
                 {
                     "detail": [
                         {
-                            "type": "value_error",
+                            "type": "datetime_from_date_parsing",
                             "loc": ["body", "end_date"],
-                            "msg": "Value error, Invalid isoformat string: '2020-11-10T12:4po'",
+                            "msg": "Input should be a valid datetime or date, unexpected extra characters at the end of the input",
                             "input": "2020-11-10T12:4po",
-                            "ctx": {"error": {}},
+                            "ctx": {"error": "unexpected extra characters at the end of the input"},
                         }
                     ]
                 },
@@ -2263,11 +2279,10 @@ def test_should_respond_404_for_nonexistent_dagrun_id(self, test_client, session
                 {
                     "detail": [
                         {
-                            "type": "value_error",
+                            "type": "timezone_aware",
                             "loc": ["body", "start_date"],
-                            "msg": "Value error, Invalid datetime format, Naive datetime is disallowed",
+                            "msg": "Input should have timezone info",
                             "input": "2020-11-10T12:42:39.442973",
-                            "ctx": {"error": {}},
                         }
                     ]
                 },
@@ -2277,11 +2292,11 @@ def test_should_respond_404_for_nonexistent_dagrun_id(self, test_client, session
                 {
                     "detail": [
                         {
-                            "type": "value_error",
+                            "type": "datetime_from_date_parsing",
                             "loc": ["body", "start_date"],
-                            "msg": "Value error, Invalid isoformat string: '2020-11-10T12:4po'",
+                            "msg": "Input should be a valid datetime or date, unexpected extra characters at the end of the input",
                             "input": "2020-11-10T12:4po",
-                            "ctx": {"error": {}},
+                            "ctx": {"error": "unexpected extra characters at the end of the input"},
                         }
                     ]
                 },