Remove superfluous @Sentry.enrich_errors (#37002)

* Remove superfluous `@Sentry.enrich_errors` from `TaskInstance._schedule_downstream_tasks` A recent refactoring broke the contract `enrich_errors` expect. This decorator is being removed because it's not desired to log Sentry errors for scheduling issues. * Fix incorrect parameter name Resolves MyPy error (cherry picked from commit 45b6b7a)
apache · Feb 20, 2024 · fedd4d4 · fedd4d4
1 parent 28852bd
commit fedd4d4
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/airflow/models/taskinstance.py b/airflow/models/taskinstance.py
@@ -3248,7 +3248,6 @@ def ti_selector_condition(cls, vals: Collection[str | tuple[str, int]]) -> Colum
 
     @classmethod
     @internal_api_call
-    @Sentry.enrich_errors
     @provide_session
     def _schedule_downstream_tasks(
         cls,

diff --git a/airflow/sentry.py b/airflow/sentry.py
@@ -161,8 +161,7 @@ def enrich_errors(self, func):
             """
             Decorate errors.
 
-            Wrap TaskInstance._run_raw_task and LocalTaskJob._run_mini_scheduler_on_child_tasks
-            to support task specific tags and breadcrumbs.
+            Wrap TaskInstance._run_raw_task to support task specific tags and breadcrumbs.
             """
             session_args_idx = find_session_idx(func)
 

diff --git a/airflow/serialization/pydantic/taskinstance.py b/airflow/serialization/pydantic/taskinstance.py
@@ -396,7 +396,7 @@ def schedule_downstream_tasks(self, session: Session = NEW_SESSION, max_tis_per_
         :meta: private
         """
         return TaskInstance._schedule_downstream_tasks(
-            ti=self, sessions=session, max_tis_per_query=max_tis_per_query
+            ti=self, session=session, max_tis_per_query=max_tis_per_query
         )
 
     def command_as_list(