Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3ToSnowflakeTransfer enforces usage of schema parameter #12001

Closed
davido912 opened this issue Oct 31, 2020 · 2 comments · Fixed by #15817
Closed

S3ToSnowflakeTransfer enforces usage of schema parameter #12001

davido912 opened this issue Oct 31, 2020 · 2 comments · Fixed by #15817
Labels
good first issue kind:bug This is a clearly a bug provider:amazon AWS/Amazon - related issues provider:snowflake Issues related to Snowflake provider

Comments

@davido912
Copy link
Contributor

davido912 commented Oct 31, 2020 •
edited
Loading

Unlike all other Snowflake operators, S3ToSnowflakeTransfer requires the usage of schema instead of letting it be an optional variable that when passed would be used, and if not, then connection metadata is used.

I can be assigned on this if needed. Keeping this up here so this doesn't go unnoticed.
@davido912 davido912 added the kind:bug This is a clearly a bug label Oct 31, 2020
@eladkal
Copy link
Contributor

eladkal commented Nov 8, 2020

@davido912 assigned the issue to you :)

@davido912 davido912 mentioned this issue Nov 19, 2020
Closed
@mik-laj mik-laj mentioned this issue Dec 22, 2020
Closed
@eladkal eladkal added provider:snowflake Issues related to Snowflake provider and removed area:providers labels Feb 25, 2021
@eladkal
Copy link
Contributor

eladkal commented May 7, 2021

hi @davido912 since you didn't finish your pr #13017 I unassign you from this issue. If you wish to complete it feel free to do so.

This issue is open for anyone who wants to pick it.

@uranusjr uranusjr mentioned this issue May 13, 2021
Merged
kaxil pushed a commit that referenced this issue May 13, 2021
@uranusjr
Allow S3ToSnowflakeOperator to omit schema (#15817)
6f956dc 
Fix #12001.

As a drive-by cleanup, I also rewrote the text-building logic a bit to remove superfulous spaces and blank lines in the query string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue kind:bug This is a clearly a bug provider:amazon AWS/Amazon - related issues provider:snowflake Issues related to Snowflake provider
Projects
None yet
Milestone
No milestone
2 participants
@eladkal @davido912