Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pip check in CI pipelines #12508

Closed
turbaszek opened this issue Nov 20, 2020 · 7 comments
Closed

Run pip check in CI pipelines #12508

turbaszek opened this issue Nov 20, 2020 · 7 comments
Labels
area:CI Airflow's tests and continious integration area:dependencies Issues related to dependencies problems kind:feature Feature Requests

Comments

@turbaszek
Copy link
Member

Description

We should consider adding pip check command in our CI system to verify that dependencies that we use (together with constrains) are fully compatible. This should be run for biggest possible user-installation (apache-airflow[all]).

Use case / motivation

Successful pip check is often a business requirement for releasing new version of Airflow. It assure us that all dependencies we use to build and run Airflow are compatible and we won't face any unexpected errors.

Related Issues

N/A

@turbaszek turbaszek added kind:feature Feature Requests area:CI Airflow's tests and continious integration labels Nov 20, 2020
@turbaszek
Copy link
Member Author

CC @potiuk @mhenc @anitakar

@ashb
Copy link
Member

ashb commented Nov 20, 2020

We'll have to fix the conflicts first ;)

snowflake-connector-python 2.2.10 has requirement azure-storage-blob<13.0.0,>=12.0.0; python_version >= "3.5.2", but you have azure-storage-blob 2.1.0.
snowflake-connector-python 2.2.10 has requirement cryptography<3.0.0,>=2.5.0, but you have cryptography 3.0.
snowflake-connector-python 2.2.10 has requirement idna<2.10, but you have idna 2.10.
snowflake-connector-python 2.2.10 has requirement requests<2.24.0, but you have requests 2.24.0.
moto 1.3.14 has requirement idna<2.9,>=2.5, but you have idna 2.10.
cfn-lint 0.35.0 has requirement importlib-resources~=1.4; python_version < "3.7" and python_version != "3.4", but you have importlib-resources 3.0.0.
botocore 1.17.44 has requirement docutils<0.16,>=0.10, but you have docutils 0.16.
astroid 2.4.2 has requirement lazy-object-proxy==1.4.*, but you have lazy-object-proxy 1.5.1.

@ashb
Copy link
Member

ashb commented Nov 20, 2020

(That list is a lot better than it used to be)

@turbaszek
Copy link
Member Author

We'll have to fix the conflicts first ;)

Yes and that's not all 🗻

@turbaszek
Copy link
Member Author

Running on latest docker image:

➜ docker run -it --entrypoint /bin/bash apache/airflow
airflow@2efb9f6adf36:/opt/airflow$ pip check
slackclient 1.3.2 has requirement websocket-client<0.55.0,>=0.35, but you have websocket-client 0.57.0.
botocore 1.17.44 has requirement docutils<0.16,>=0.10, but you have docutils 0.16.

@potiuk
Copy link
Member

potiuk commented Nov 20, 2020

We'll have to fix the conflicts first ;)
Yep. Isssue waiting to be done #10854

@turbaszek turbaszek added the area:dependencies Issues related to dependencies problems label Nov 22, 2020
turbaszek added a commit to PolideaInternal/airflow that referenced this issue Nov 25, 2020
This is first step to address apache#12508

fixup! Run pip check when to verify production images

fixup! Run pip check when to verify production images
@mik-laj
Copy link
Member

mik-laj commented Oct 19, 2021

Done:

@mik-laj mik-laj closed this as completed Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:CI Airflow's tests and continious integration area:dependencies Issues related to dependencies problems kind:feature Feature Requests
Projects
None yet
Development

No branches or pull requests

4 participants