Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint Dockerfile - pre_commit_lint_dockerfile.sh takes too long or gets stuck #17494

Closed
subkanthi opened this issue Aug 8, 2021 · 3 comments
Closed

Lint Dockerfile - pre_commit_lint_dockerfile.sh takes too long or gets stuck #17494

subkanthi opened this issue Aug 8, 2021 · 3 comments
Labels
area:dev-env CI, pre-commit, pylint and other changes that do not change the behavior of the final code good first issue kind:bug This is a clearly a bug

Comments

@subkanthi
Copy link
Contributor

subkanthi commented Aug 8, 2021 •
edited
Loading

On Mac M1, the "Lint Dockerfile" pre-commit step takes forever to complete. Need to troubleshoot and add a fix for this problem.

Environment:
Docker version 20.10.6, build 370c289
Mac M1 Big Sur
@subkanthi subkanthi added the kind:bug This is a clearly a bug label Aug 8, 2021
@potiuk
Copy link
Member

potiuk commented Aug 8, 2021 •
edited
Loading

You can always disable it by setting SKIP variable in the meantime https://pre-commit.com/#temporarily-disabling-hooks (as a workaround)

@subkanthi
Copy link
Contributor Author

You can always disable it by setting SKIP variable in the meantime https://pre-commit.com/#temporarily-disabling-hooks (as a workaround)

Thanks that helps for now

@eladkal eladkal added area:dev-env CI, pre-commit, pylint and other changes that do not change the behavior of the final code good first issue labels Sep 21, 2021
@potiuk
Copy link
Member

potiuk commented Mar 9, 2022

Until This one is fixed hadolint/hadolint#411 , I will permanently disable Hadolint from pre-commits hen run on arm platform in #22127

potiuk added a commit to potiuk/airflow that referenced this issue Mar 10, 2022
@potiuk
Add support for ARM platform
ed1a1f4 
This support is mostly for the developers, not for CI full chain yet.
It has several limitations:

* no MySQL client support
* no MsSQL client support
* no CI tests yet

What is implemented:

* automated detection of ARM/AMD architecture when building and
  running breeze
* automated cache refresh on CI for ARM/AMD

Currently only development (ghcr.io) images are supported for ARM.

Fixes: apache#18849
Fixes: apache#17494
Relates to: apache#15635

The images published in DockerHub for now are AMD64 only. We will
run development with M1 images for some time and later we will
likely make our DockerHub images multi-platform as well.

Also Hadolint does not have ARM images yet so we had to disable it
and we should re-enable it back after the support is added.
See hadolint/hadolint#411
@potiuk potiuk closed this as completed in 828d1cb Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:dev-env CI, pre-commit, pylint and other changes that do not change the behavior of the final code good first issue kind:bug This is a clearly a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@potiuk @subkanthi @eladkal