-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken json_client #17527
Labels
kind:bug
This is a clearly a bug
Comments
Thanks for opening your first issue here! Be sure to follow the issue template! |
This was probably missed when we migrated from requests to httpx. Would you be able to submit a pull request for this? |
kaxil
pushed a commit
that referenced
this issue
Aug 10, 2021
The json_client depends on httpx and thus the response doesn't contain the attribute 'ok'. In consequence, the missing attribute has been changed to is_error. closes: #17527 Co-authored-by: Szymon Wojciechowski <szymon.wojciechowski@here.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Apache Airflow version: 2.1.2
Apache Airflow Provider versions (please include all providers that are relevant to your bug):
apache-airflow-providers-ftp==2.0.0
apache-airflow-providers-imap==2.0.0
apache-airflow-providers-sqlite==2.0.0
Environment:
What happened:
Json Client depends on httpx, which doesn't provide the attribute 'ok' and according to their spec (https://www.python-httpx.org/compatibility/) they are not going to do that. In the consequence handling the response crashes.
What you expected to happen:
The expected outcome is to handle the response smoothly.
How to reproduce it:
Anything else we need to know:
The problem always occurs.
The text was updated successfully, but these errors were encountered: