Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of testing Providers that were prepared on January 02, 2023 #28679

Closed
35 of 84 tasks
eladkal opened this issue Jan 2, 2023 · 14 comments
Closed
35 of 84 tasks

Status of testing Providers that were prepared on January 02, 2023 #28679

eladkal opened this issue Jan 2, 2023 · 14 comments
Labels
kind:meta High-level information important to the community testing status Status of testing releases

Comments

@eladkal
Copy link
Contributor

eladkal commented Jan 2, 2023

Body

I have a kind request for all the contributors to the latest provider packages release.
Could you please help us to test the RC versions of the providers?

Let us know in the comment, whether the issue is addressed.

Those are providers that require testing as there were some substantial changes introduced:

Provider amazon: 7.0.0rc2

Provider apache.hive: 5.1.0rc2

Provider atlassian.jira: 2.0.0rc2

Provider cncf.kubernetes: 5.1.0rc2

Provider common.sql: 1.3.2rc2

Provider docker: 3.4.0rc2

Provider elasticsearch: 4.3.2rc2

Provider ftp: 3.3.0rc2

Provider google: 8.7.0rc2

Provider imap: 3.1.1rc2

Provider microsoft.azure: 5.0.2rc2

Provider microsoft.mssql: 3.3.2rc2

Provider microsoft.winrm: 3.1.1rc2

Provider oracle: 3.6.0rc2

Provider postgres: 5.4.0rc2

Provider presto: 4.2.1rc2

Provider salesforce: 5.3.0rc2

Provider sftp: 4.2.1rc2

Provider slack: 7.1.1rc2

Provider ssh: 3.4.0rc2

Provider telegram: 3.1.1rc2

Provider trino: 4.3.1rc2

The guidelines on how to test providers can be found in

Verify providers by contributors

All users involved in the PRs:
@Taragolis @syedahsn @xinbinhuang @vchiapaikeo @ferruzzi @jon-evergreen @RachitSharma2001 @syun64 @snjypl @pankajastro @thangnd197 @dwreeves @eladkal @KarshVashi @BobDu @hankehly @xjf729 @Adityamalik123
@jbandoro @IAL32 @lwyszomi @moiseenkov @VladaZakharova @stamixthereal @vincbeck @2h-kim @kolfild26 @potiuk @raphaelauv @TohnJhomas @dstandish @vandonr-amz @romibuzi @mdering @skabbit @odaneau-astro
@kouk

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@eladkal eladkal added kind:meta High-level information important to the community testing status Status of testing releases labels Jan 2, 2023
@vandonr-amz
Copy link
Contributor

✅ for me, as our CI ran the example DAGs sucessfully, which include the newly introduced operators/sensors.

@vchiapaikeo
Copy link
Contributor

Reran our test dags and they both looked good:

image

@hankehly
Copy link
Contributor

hankehly commented Jan 3, 2023

#28108 is a document-only change (docs build successfully)

@stamixthereal
Copy link
Contributor

#28617 also looks good on my local, anyway it is a small change

@potiuk
Copy link
Member

potiuk commented Jan 4, 2023

All Good:

I had no hive and connection defined, but it was correctly added and used by JINJA and was clearly taken from hive provider, not airflow core:

  File "/opt/airflow/airflow/providers/apache/hive/macros/hive.py", line 49, in max_partition
    hive_hook = HiveMetastoreHook(metastore_conn_id=metastore_conn_id)
  File "/opt/airflow/airflow/providers/apache/hive/hooks/hive.py", line 485, in __init__
    self.conn = self.get_connection(metastore_conn_id)
  File "/opt/airflow/airflow/hooks/base.py", line 72, in get_connection
    conn = Connection.get_connection_from_secrets(conn_id)
  File "/opt/airflow/airflow/models/connection.py", line 435, in get_connection_from_secrets
    raise AirflowNotFoundException(f"The conn_id `{conn_id}` isn't defined")
airflow.exceptions.AirflowNotFoundException: The conn_id `metastore_default` isn't defined

Also it is visible in Airflow Webserver as Plugin when the new hive provider is installed (missing when installing hive provider 5.0.0):

Screenshot 2023-01-04 at 09 58 17

@Taragolis
Copy link
Contributor

Taragolis commented Jan 4, 2023

#28555: This only affect CI and it pass

#28507, #27775, #27858: Working fine

#28279: Check on AWS environment, work fine

#28505 - @potiuk I've found that we try to import numpy before pandas and in case of pandas not installed we more more likely get ModuleNotFoundError raised instead of AirflowOptionalProviderFeatureException. numpy is a core dependency for pandas and it is not a dependency of airflow itself. I've check on slim image of airflow 2.3.4, 2.4.3 and 2.5.0. It is not critical - no raise any error during airflow services starts

import numpy as np
try:
import pandas as pd
except ImportError as e:
from airflow.exceptions import AirflowOptionalProviderFeatureException
raise AirflowOptionalProviderFeatureException(e)

  File "/opt/airflow/dags/example_aws.py", line 5, in <module>
    from airflow.providers.amazon.aws.transfers.sql_to_s3 import SqlToS3Operator
  File "/home/airflow/.local/lib/python3.9/site-packages/airflow/providers/amazon/aws/transfers/sql_to_s3.py", line 25, in <module>
    import numpy as np
ModuleNotFoundError: No module named 'numpy'

@eladkal
Copy link
Contributor Author

eladkal commented Jan 4, 2023

I've found that we try to import numpy before pandas and in case of pandas not installed we more more likely get ModuleNotFoundError raised instead of AirflowOptionalProviderFeatureException

I don't think this is a concern...
This is a dependency of a dependency.
If you use library directly you should make sure you install it and not relay on another package to do that for you.

@potiuk
Copy link
Member

potiuk commented Jan 4, 2023

I don't think this is a concern...

Agree. It's just "less clear" exception in this case, not a blocker for sure. But I will add a fix for the next version.

@Taragolis
Copy link
Contributor

Agree. It's just "less clear" exception in this case, not a blocker for sure. But I will add a fix for the next version.

Yeah agree can do it later. This kind of import only critical if it optional part of Hooks, not a operators. We could just move it inside try.. except and suggest to install by extra pip install apache-airflow-providers-amazon[pandas]

@romibuzi
Copy link
Contributor

romibuzi commented Jan 4, 2023

#27893 all good with a integration test:

image_2023-01-04_11 58 41

image_2023-01-04_11 59 08

@pankajastro
Copy link
Member

Tested #27943 #28639 #28522 Looks good

@kolfild26
Copy link
Contributor

Both #27319 and #27370 seem to be 🆗

@jbandoro
Copy link
Contributor

jbandoro commented Jan 4, 2023

Tested #28235 and it looks good, thanks!

@eladkal
Copy link
Contributor Author

eladkal commented Jan 5, 2023

Thank you everyone.
Providers are released thus closing the issue.
I invite everyone to help improve providers for the next release, a list of open bugs can be found here.

@eladkal eladkal closed this as completed Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:meta High-level information important to the community testing status Status of testing releases
Projects
None yet
Development

No branches or pull requests