Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: re-enable use of parameters in gcs_to_bq which had been disabled #27961

Merged
merged 4 commits into from
Dec 4, 2022

Conversation

mdering
Copy link
Contributor

@mdering mdering commented Nov 28, 2022

closes #27842

Add in some missing configuration options to the gcs to bq transfer operator. the 8.5.0 release broke a number of things with this operator, mainly the methods to specify the file delimiter, and the time partitioning option.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Nov 28, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 28, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@uranusjr
Copy link
Member

CI is failing.

@mdering
Copy link
Contributor Author

mdering commented Nov 29, 2022

@uranusjr I see why, can you approve it to rerun tests?

@mdering
Copy link
Contributor Author

mdering commented Nov 30, 2022

Is there something you need from me to rerun this?

@eladkal
Copy link
Contributor

eladkal commented Nov 30, 2022

Is there something you need from me to rerun this?

Can you please add unit test to avoid regression?

@mdering
Copy link
Contributor Author

mdering commented Nov 30, 2022

@eladkal yes, I added some tests, and fixed the existing tests

@mdering mdering changed the title add some missing options for the gcs to bq operator re-enable use of parameters in gcs_to_bq which had been disabled Nov 30, 2022
@mdering mdering changed the title re-enable use of parameters in gcs_to_bq which had been disabled Fix: re-enable use of parameters in gcs_to_bq which had been disabled Dec 1, 2022
@mdering
Copy link
Contributor Author

mdering commented Dec 1, 2022

since this passed CI and has unit tests, is there anything else I need to do to get this merged?

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool.

@potiuk potiuk merged commit 2d663df into apache:main Dec 4, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 4, 2022

Awesome work, congrats on your first merged pull request!

@mdering mdering deleted the gcs-to-bq-compatibility branch December 27, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GCSToBigQueryOperator no longer uses field_delimiter or time_partitioning
4 participants