-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: re-enable use of parameters in gcs_to_bq which had been disabled #27961
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
CI is failing. |
@uranusjr I see why, can you approve it to rerun tests? |
Is there something you need from me to rerun this? |
Can you please add unit test to avoid regression? |
@eladkal yes, I added some tests, and fixed the existing tests |
since this passed CI and has unit tests, is there anything else I need to do to get this merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool.
Awesome work, congrats on your first merged pull request! |
closes #27842
Add in some missing configuration options to the gcs to bq transfer operator. the 8.5.0 release broke a number of things with this operator, mainly the methods to specify the file delimiter, and the time partitioning option.