Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching task instances by state doesn't work #31156

Closed
1 of 2 tasks
zachliu opened this issue May 9, 2023 · 4 comments · Fixed by #31203
Closed
1 of 2 tasks

Searching task instances by state doesn't work #31156

zachliu opened this issue May 9, 2023 · 4 comments · Fixed by #31203
Labels
area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet

Comments

@zachliu
Copy link
Contributor

zachliu commented May 9, 2023

Apache Airflow version

2.6.0

What happened

After specifying a state such as "Equal to" "failed", the search doesn't return anything but resetting the whole page (the specified filter is gone)

Screencast.2023-05-09.10.31.53.mp4

What you think should happen instead

No response

How to reproduce

Go to "Browse" tab -> click "Task Instances" -> "Add Filter" -> "State" -> "Use anything (equal to, contains, etc)" -> Click "Search"

Operating System

Debian GNU/Linux 10 (buster)

Versions of Apache Airflow Providers

No response

Deployment

Other Docker-based deployment

Deployment details

No response

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@zachliu zachliu added area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels May 9, 2023
@VVildVVolf
Copy link
Contributor

VVildVVolf commented May 10, 2023

Looking into it.

UPD: reproduced, investigating the best way to fix.

@VVildVVolf
Copy link
Contributor

The problem is related to flask-appbuilder. To be precise, it's usage of select2:

You can see in address bar, after clicking "Search", the address would became /taskinstance/list/?_flt_undefined_state=failed. But if you change it manually to something like /taskinstance/list/?_flt_3_state=failed, you will see that everything works fine. So, the problem does not look on airflow side.

Please, correct me if you see different picture.

I created a PR for fba according to select2's recommendation, but not sure if it will be merged (at least soon).

On the other hand, looks like it might hard to update fba for the airflow itself.

@potiuk, can we theoretically upgrade fba to 4.3.1? looks like fba already has some changes of this point, but honesly not sure if it does fix the problem itself yet (because of P.S. bellow).
P.S. I tried to check 4.3.1 locally (PR: #31203), but breeze says that there is a restriction to use 4.3.1 instead of 4.3.0. I have not found yet how to disable it, if you would provide a hint - it will be very helpfull :)

@pankajastro
Copy link
Member

I think we can close this one since #31203 has merged

@potiuk potiuk linked a pull request May 15, 2023 that will close this issue
@potiuk
Copy link
Member

potiuk commented May 15, 2023

U liked the PR and closing this one then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants