-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade FAB to 4.3.1 #31203
Upgrade FAB to 4.3.1 #31203
Conversation
Did you check if there are no changes in security classes folowing this comment?
|
You can see example changes that needed to be |
@potiuk ,
Yes, I am already using https://github.com/apache/airflow/pull/29766/files as a reference, thanks!
Mostly I was focused on checking if upgrade of FAB does help or not with the issue #31156 . Good news that upgrading to 4.3.1 helps (but hard to be covered by Unit test, investigating if it is possible). The review of P.S. Just for history maybe it will help someone: to update FAB locally helped:
|
From what I understand (I have not done it originally) the security manager was ported "partially" (that is what makes it difficult) - some parts of security manager is completely not used by us (and we did not port it), but some other (authentication types) are - and only changes to those should be ported. |
It looks like the difference v4.3.0 vs v4.3.1 looks pretty minor, but includes the change we need. flask_appbuilder/security was not touched. |
Thanks! |
(cherry picked from commit 1133035)
(cherry picked from commit 1133035)
Flask-ApplicationBuilder v4.3.0 has a bug with usage
Select2
control. It is fixed in v4.3.1. The description is mentioned in issue #31156v4.3.0 vs v4.3.1 looks pretty minor, but includes the change we need. flask_appbuilder/security was not touched.