Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hashicorp Vault: KvV2.create_or_update_secret() got an unexpected keyword argument 'secret_path' #37619

Closed
1 of 2 tasks
Blizzke opened this issue Feb 22, 2024 · 2 comments · Fixed by #37626
Closed
1 of 2 tasks
Assignees
Labels
area:providers good first issue kind:bug This is a clearly a bug provider:hashicorp Hashicorp provider related issues

Comments

@Blizzke
Copy link

Blizzke commented Feb 22, 2024

Apache Airflow Provider(s)

hashicorp

Versions of Apache Airflow Providers

apache-airflow-providers-hashicorp==3.6.3

Apache Airflow version

2.8.1

Operating System

arch

Deployment

Virtualenv installation

Deployment details

_VaultClient.create_or_update_secret() calls the underlying KV engine with a secret_path keyword parameter that should've been path:

File ".../.venv/lib/python3.11/site-packages/airflow/providers/hashicorp/_internal_client/vault_client.py", line 474, in create_or_update_secret
    response = self.client.secrets.kv.v2.create_or_update_secret(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: KvV2.create_or_update_secret() got an unexpected keyword argument 'secret_path'

What happened

When using this functionality it fails given the above error message.

What you think should happen instead

If the create_or_update_secret functionality is provided, it should work as intended.

How to reproduce

Call create_or_update_secret, via the VaultHook for example.

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@Blizzke Blizzke added area:providers kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Feb 22, 2024
@potiuk potiuk added good first issue and removed needs-triage label for new issues that we didn't triage yet labels Feb 22, 2024
@eladkal eladkal added the provider:hashicorp Hashicorp provider related issues label Feb 22, 2024
@eladkal eladkal changed the title Hashicorp Value: Hashicorp Vault: VAULT_CAPATH & VAULT_CACERT broken by pre-creating session to pass along Feb 22, 2024
@eladkal eladkal changed the title Hashicorp Vault: VAULT_CAPATH & VAULT_CACERT broken by pre-creating session to pass along Hashicorp Vault: KvV2.create_or_update_secret() got an unexpected keyword argument 'secret_path' Feb 22, 2024
@tungbq
Copy link
Contributor

tungbq commented Feb 22, 2024

Hi team, can I work on this issue?

@potiuk
Copy link
Member

potiuk commented Feb 22, 2024

feel free

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers good first issue kind:bug This is a clearly a bug provider:hashicorp Hashicorp provider related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants