Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unexpected keyword argument 'secret_path' in secrets.kv.v2 #37626

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

tungbq
Copy link
Contributor

@tungbq tungbq commented Feb 22, 2024

Closes: #37619
Fix unexpected keyword argument 'secret_path' in secrets.kv.v2
Called self.client.secrets.kv.v2.create_or_update_secret() function with path argument instead
Document: https://hvac.readthedocs.io/en/stable/usage/secrets_engines/kv_v2.html#create-update-secret


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link

boring-cyborg bot commented Feb 22, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems no one uses this method in the hook, the bug has been around for years with no reported issues.

Copy link
Collaborator

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hussein-awala hussein-awala merged commit 3568b09 into apache:main Feb 23, 2024
58 checks passed
@Blizzke
Copy link

Blizzke commented Feb 23, 2024

It seems no one uses this method in the hook, the bug has been around for years with no reported issues.

I was planning on using it, otherwise I wouldn't have encountered the bug 😉
But I mean, I didn't expect to find that method there since the secrets backends don't support (as far as I know) the creation of new secrets, that has to be handled externally. So if the decision is made to remove it, I don't think anyone would miss it (except perhaps the unit tests?)

@eladkal eladkal added the provider:hashicorp Hashicorp provider related issues label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:hashicorp Hashicorp provider related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hashicorp Vault: KvV2.create_or_update_secret() got an unexpected keyword argument 'secret_path'
5 participants