Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra slash from update_job_permission api #38919

Closed
2 tasks done
SubhamSinghal opened this issue Apr 11, 2024 · 1 comment
Closed
2 tasks done

Remove extra slash from update_job_permission api #38919

SubhamSinghal opened this issue Apr 11, 2024 · 1 comment

Comments

@SubhamSinghal
Copy link
Contributor

Apache Airflow Provider(s)

databricks

Versions of Apache Airflow Providers

apache-airflow-providers-common-io==1.2.0
apache-airflow-providers-common-sql==1.10.0
apache-airflow-providers-databricks==6.1.0
apache-airflow-providers-ftp==3.7.0
apache-airflow-providers-http==4.8.0
apache-airflow-providers-imap==3.5.0
apache-airflow-providers-sqlite==3.7.0

Apache Airflow version

2.8.1

Operating System

ubuntu

Deployment

Google Cloud Composer

Deployment details

No response

What happened

Update job permission failed due to extra slash

What you think should happen instead

Update job permission should have updated job permissions

How to reproduce

Create a job config with access control list.

 access_control = [{
            "group_name": "abc",
            "permission_level": "CAN_MANAGE_RUN"
        }]

In the first run CreateJobOperator updates ACL properly. Now update ACL list and run CreateJobOperator again.

access_control = [{
           "group_name": "abc",
           "permission_level": "CAN_MANAGE_RUN"
       },
       {
           "group_name": "def",
           "permission_level": "CAN_MANAGE_RUN"
       }
]

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@SubhamSinghal SubhamSinghal added area:providers kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Apr 11, 2024
@eladkal
Copy link
Contributor

eladkal commented Apr 12, 2024

fixed in #38918
@SubhamSinghal you can always open PR directly, no need to open issue first

@eladkal eladkal closed this as completed Apr 12, 2024
@eladkal eladkal added provider:databricks and removed needs-triage label for new issues that we didn't triage yet labels Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants