Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra slash from update permission endpoint #38918

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

SubhamSinghal
Copy link
Contributor

@SubhamSinghal SubhamSinghal commented Apr 11, 2024

Fix issue: #38919
Update_job_permission is not working as there is extra slash in the beginning of API.

@SubhamSinghal
Copy link
Contributor Author

@Lee-W Can you help with failing tests here?

@eladkal eladkal requested a review from Lee-W April 11, 2024 12:02
@Lee-W Lee-W merged commit 4a669fb into apache:main Apr 11, 2024
41 checks passed
@SubhamSinghal
Copy link
Contributor Author

SubhamSinghal commented Apr 11, 2024

@Lee-W I see one issue here, Update permission takes jobId as path parameter, how can I pass path parameter through do_api_call function.

@SubhamSinghal
Copy link
Contributor Author

Added fix in this PR: #38962

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants