Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way of going back to the DAG page once entering task details #39023

Closed
1 of 2 tasks
csp33 opened this issue Apr 15, 2024 · 6 comments · Fixed by #39223
Closed
1 of 2 tasks

No way of going back to the DAG page once entering task details #39023

csp33 opened this issue Apr 15, 2024 · 6 comments · Fixed by #39223
Labels
affected_version:2.9 area:core area:UI Related to UI/UX. For Frontend Developers. good first issue kind:bug This is a clearly a bug

Comments

@csp33
Copy link
Contributor

csp33 commented Apr 15, 2024

Apache Airflow version

2.9.0

If "Other Airflow 2 version" selected, which one?

No response

What happened?

Once entering the Task Details view, there's no way to directly go back to the DAG page.
image

In Airflow 2.8.4, we could still use the old navigation tabs (i.e Grid) to go back to the DAG page
image

What you think should happen instead?

There should be a button to go back to the DAG page

How to reproduce

  1. Enter the More Details page of a TaskInstance.
  2. Try to go back to the DAG page

Operating System

Airflow in Kubernetes

Versions of Apache Airflow Providers

No response

Deployment

Official Apache Airflow Helm Chart

Deployment details

No response

Anything else?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@csp33 csp33 added area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Apr 15, 2024
@nathadfield nathadfield added good first issue area:UI Related to UI/UX. For Frontend Developers. labels Apr 15, 2024
@ecodina
Copy link
Contributor

ecodina commented Apr 16, 2024

I can confirm this also happens to us. In our case, we use a custom email template, using {{ ti.log_url }}, which redirects to this "new" page without a proper way to view the grid. Another thing I noticed is that at the top right it appears as "Schedule: False".

@eladkal eladkal added affected_version:2.9 and removed needs-triage label for new issues that we didn't triage yet labels Apr 18, 2024
@bbovenzi
Copy link
Contributor

Let's finally finish feature parity with this and the new UI then and redirect to the task page with the appropriate tab selected.

@AetherUnbound
Copy link
Contributor

AetherUnbound commented Apr 22, 2024

I'd love to jump on this if possible! One question though, even if we use the new grid view with tab=logs, it doesn't seem like we're able to automatically link to the logs of a specific try number. Should that be a separate issue/feature?

@AetherUnbound
Copy link
Contributor

@bbovenzi It actually looks like there's more detail available via the "More Details" link than is present on the Details tab of the grid view. The "Rendered Templates" link is covered sufficiently I believe, but there are tons of other fields that are present there which aren't present on the Details tab. How would you like to proceed? I can get a PR up for the ti.log_url change, but it seems like those pages still have some merit and it might be best to add the header @csp33 points to in their screenshot and officially remove the other pages (/log, /task, and /rendered-template) in another issue.

@bbovenzi
Copy link
Contributor

Yeah, for 2.9.1 let's add a Grid button in task_instance.html. It can be inside the already existing <ul> of all the other buttons. That would be a good first issue for anyone to take on.

@csp33
Copy link
Contributor Author

csp33 commented Apr 24, 2024

Yeah, for 2.9.1 let's add a Grid button in task_instance.html. It can be inside the already existing <ul> of all the other buttons. That would be a good first issue for anyone to take on.

I can try to do it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected_version:2.9 area:core area:UI Related to UI/UX. For Frontend Developers. good first issue kind:bug This is a clearly a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants