Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use grid view for Task Instance's log_url #39183

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Use grid view for Task Instance's log_url #39183

merged 2 commits into from
Apr 24, 2024

Conversation

AetherUnbound
Copy link
Contributor

@AetherUnbound AetherUnbound commented Apr 23, 2024 •
edited
Loading

Related to #39023, #39179

This PR changes the Task Instance's log_url to use the logs tab of the Grid view UI, rather than the /log page for the specific task instance result.

@uranusjr uranusjr requested a review from bbovenzi April 23, 2024 03:12
@uranusjr
Copy link
Member

LGTM but deferring to @bbovenzi

bbovenzi
bbovenzi requested changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need to update another test which expects the old url

@AetherUnbound
Copy link
Contributor Author

@bbovenzi there's one test that's failing but it looks like it might be a flakey one, would you mind re-running it?

@bbovenzi bbovenzi added this to the Airflow 2.9.1 milestone Apr 24, 2024
@bbovenzi bbovenzi merged commit 6db6fef into apache:main Apr 24, 2024
42 checks passed
@AetherUnbound AetherUnbound deleted the fix/task-instance-log-url branch April 24, 2024 17:01
@AetherUnbound AetherUnbound mentioned this pull request Apr 24, 2024
Closed
@jedcunningham jedcunningham added the type:bug-fix Changelog: Bug Fixes label Apr 26, 2024
jedcunningham pushed a commit that referenced this pull request Apr 26, 2024
@AetherUnbound @jedcunningham
Use grid view for Task Instance's log_url (#39183)
7cd311d 
* Use grid view for Task Instance's `log_url`

* Update other tests

(cherry picked from commit 6db6fef)
@ephraimbuddy ephraimbuddy mentioned this pull request Apr 30, 2024
Closed
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbovenzi bbovenzi bbovenzi approved these changes

@kaxil kaxil Awaiting requested review from kaxil

@XD-DENG XD-DENG Awaiting requested review from XD-DENG XD-DENG is a code owner

@ashb ashb Awaiting requested review from ashb ashb is a code owner

Assignees
No one assigned
Labels
type:bug-fix Changelog: Bug Fixes
Projects
None yet
Milestone
Airflow 2.9.1
Development

Successfully merging this pull request may close these issues.
4 participants
@AetherUnbound @uranusjr @bbovenzi @jedcunningham