RuntimeTaskInstance context does not contain `log_url`

[jnstockley]

Apache Airflow version

3.0.0

If "Other Airflow 2 version" selected, which one?

No response

What happened?

The Task Context does not contain the log_url parameter, this causes SmtpNotifier to fail to send email when using on_failure_callback, on_success_callback, etc. SmtpNotifier fails since in the jinja2 email template it requires ti.log_url

What you think should happen instead?

Tek Task context should include log_url or the jinja2 should be updated by removing log_url or using a different way to include log_url

How to reproduce

Create a task as follows

@task()
    def send_email(**context):
        ti: RuntimeTaskInstance = context['ti']

        smtp = SmtpNotifier(to=to_email, smtp_conn_id="SMTP", from_email=from_email')
        smtp.notify(context)

Check error logs stating

[2025-05-08, 01:28:34] ERROR - Task failed with exception: source="task"
UndefinedError: 'airflow.sdk.execution_time.task_runner.RuntimeTaskInstance object' has no attribute 'log_url'
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/task_runner.py", line 838 in run
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/task_runner.py", line 1130 in _execute_task
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/bases/operator.py", line 408 in wrapper
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/bases/decorator.py", line 251 in execute
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/bases/operator.py", line 408 in wrapper
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/providers/standard/operators/python.py", line 212 in execute
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/providers/standard/operators/python.py", line 235 in execute_callable
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/callback_runner.py", line 81 in run
File "/opt/airflow/dags/Airflow_Cleanup.py", line 98 in send_email
File "/opt/airflow/plugins/notifier/SMTP.py", line 149 in notify
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/definitions/_internal/templater.py", line 121 in _do_render_template_fields
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/definitions/_internal/templater.py", line 177 in render_template
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/bases/notifier.py", line 57 in _render
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/definitions/_internal/templater.py", line 133 in _render
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/utils/helpers.py", line 244 in render_template_to_string
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/utils/helpers.py", line 239 in render_template
File "<template>", line 37 in root
File "/home/airflow/.local/lib/python3.12/site-packages/jinja2/runtime.py", line 859 in _fail_with_undefined_error

Operating System

Linux

Versions of Apache Airflow Providers

apache-airflow-providers-common-compat==1.6.1

Deployment

Other Docker-based deployment

Deployment details

Custom Docker image using official Docker images as base, https://github.com/jnstockley/airflow/blob/main/Dockerfile

Anything else?

No response

Are you willing to submit PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[boring-cyborg]

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

[ayush3singh]

Hi
I would like to take a shot at fixing this

We can wither try checking it in email template or add this in RuntimeTaskInstance

Would be great if I can get a suggestion too

Thanks

[uranusjr]

We should just add it to RuntimeTaskInstance and populate the value when a task runner is started. The execution API should be modified to pas that field to the runner. Start with task_runner.py.

[ayush3singh]

Thanks @uranusjr for the suggestion.
will start work on this by adding the field.

[jnstockley]

@ayush3singh Thanks for looking into this. I did a bit more testing today and noticed that at least one more argument is missing from the RuntimeTaskInstance class. The argument is mark_success_url. I'm assuming it's a similar issue, that's why I am mentioning it here instead of creating a new issue. I am more than happy to create a new issue if it is not similar to the existing issue. Here is the log in case that is helpful as well

[2025-05-08, 22:56:10] ERROR - Task failed with exception: source="task"
UndefinedError: 'airflow.sdk.execution_time.task_runner.RuntimeTaskInstance object' has no attribute 'mark_success_url'
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/task_runner.py", line 838 in run
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/task_runner.py", line 1130 in _execute_task
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/bases/operator.py", line 408 in wrapper
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/bases/decorator.py", line 251 in execute
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/bases/operator.py", line 408 in wrapper
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/providers/standard/operators/python.py", line 212 in execute
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/providers/standard/operators/python.py", line 235 in execute_callable
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/execution_time/callback_runner.py", line 81 in run
File "/opt/airflow/dags/Airflow_Cleanup.py", line 98 in send_email
File "/opt/airflow/plugins/notifier/SMTP.py", line 150 in notify
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/definitions/_internal/templater.py", line 121 in _do_render_template_fields
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/definitions/_internal/templater.py", line 177 in render_template
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/bases/notifier.py", line 57 in _render
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/sdk/definitions/_internal/templater.py", line 133 in _render
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/utils/helpers.py", line 244 in render_template_to_string
File "/home/airflow/.local/lib/python3.12/site-packages/airflow/utils/helpers.py", line 239 in render_template
File "<template>", line 37 in root
File "/home/airflow/.local/lib/python3.12/site-packages/jinja2/runtime.py", line 859 in _fail_with_undefined_error

[ayush3singh]

@jnstockley Thanks for mentioning it, you are right this is indeed missing too.
I will be adding then in the PR.
Looks like it should be the same URL as it is defined in TaskInstance, will populate mark_success_url too.