Replace logo with SVG that includes name in proper typography #11018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
reviewed
Sep 18, 2020
Contributor
Author
|
@ashb "I don't see where the don't is used?" typo? For smaller icon/logo SVGs, I typically opt for inline rendering and forgo the extra request. |
ashb
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #10953
Replaces the PNG + HTML text version of the Airflow logo with an SVG that yields both the pinwheel and "Airflow" text. The prior implementation simply used the default font-family (Helvetica Neue) for the brand name, where this implementation uses the brand font-family (Rubik). This ensures that brand font is always locked up with the logo in cases where an end-user may apply a custom theme (e.g. different default font-family).
I left the old static asset (
pin_100.png) in the file system as it appears to still be in use by a Slack Operator.If you stare long enough, you'll see the typography differences 😃
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.