Add D202 pydocstyle check #11032
Merged
Add D202 pydocstyle check #11032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:API
mik-laj
reviewed
Sep 20, 2020
|
Let me know when you are happy to mark the "PR ready for review" -- I think it is but just want to make sure :) |
|
Hi @kaxil sorry, I was trying to find out why I was getting a K8s error. I'll see if I get an error with the latest CI run, might need to rebase. |
|
Yeah don't worry about the Kubernetes tests, they are unrelated to the PR, looks like some transient error which we will look into. |
We have now much better user-facing documentation. Only the parts interesting for users of the image are separated out to the "docs" of Airflow. The README and IMAGES.rst contains links to those docs and internal details of the images respectively. Fixes apache#10997.
GitHub Actions allow to use `fromJson` method to read arrays or even more complex json objects into the CI workflow yaml files. This, connected with set::output commands, allows to read the list of allowed versions as well as default ones from the environment variables configured in ./scripts/ci/libraries/initialization.sh This means that we can have one plece in which versions are configured. We also need to do it in "breeze-complete" as this is a standalone script that should not source anything we added BATS tests to verify if the versions in breeze-complete correspond with those defined in the initialization.sh Also we do not limit tests any more in regular PRs now - we run all combinations of available versions. Our tests run quite a bit faster now so we should be able to run more complete matrixes. We can still exclude individual values of the matrixes if this is too much. MySQL 8 is disabled from breeze for now. I plan a separate follow up PR where we will run MySQL 8 tests (they were not run so far)
…11017)" (apache#11065) This reverts commit 1539bd0.
|
Can you rebase to the master, it should be better now |
Remove ending / from s.apache.org Slack link
|
OK sure @kaxil 😃 |
kaxil
added
provider:cncf-kubernetes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled D202 Pydocstyle check
Part of issue: #10742
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.