Spend less time waiting for LocalTaskJob's subprocss process to finish#11373
Spend less time waiting for LocalTaskJob's subprocss process to finish#11373ashb merged 2 commits intoapache:masterfrom
Conversation
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*. |
1fa0694 to
6d5a76c
Compare
6d5a76c to
a585f93
Compare
This is about is about a 20% speed up for short running tasks! This change doesn't affect the "duration" reported in the TI table, but does affect the time before the slot is freeded up from the executor - which does affect overall task/dag throughput. (All these tests are with the same BashOperator tasks, just running `echo 1`.) **Before** ``` Task airflow.executors.celery_executor.execute_command[5e0bb50c-de6b-4c78-980d-f8d535bbd2aa] succeeded in 6.597011625010055s: None Task airflow.executors.celery_executor.execute_command[0a39ec21-2b69-414c-a11b-05466204bcb3] succeeded in 6.604327297012787s: None ``` **After** ``` Task airflow.executors.celery_executor.execute_command[57077539-e7ea-452c-af03-6393278a2c34] succeeded in 1.7728257849812508s: None Task airflow.executors.celery_executor.execute_command[9aa4a0c5-e310-49ba-a1aa-b0760adfce08] succeeded in 1.7124666879535653s: None ``` **After, including change from apache#11372** ``` Task airflow.executors.celery_executor.execute_command[35822fc6-932d-4a8a-b1d5-43a8b35c52a5] succeeded in 0.5421732050017454s: None Task airflow.executors.celery_executor.execute_command[2ba46c47-c868-4c3a-80f8-40adaf03b720] succeeded in 0.5469810889917426s: None ```
a585f93 to
c0ea217
Compare
|
One heisen test failed in a slightly odd way: Do we think it's safe to merge anyway? |
You can run the tests easily now for the whole group :) . LEt me do it for you |
|
Oh you mean locally :) Of course. |
|
From what I see it failed similarly in 3 cases. Looking at the stability of the errors in the previous builds today - It looks like it's a "real" problem, |
|
And I think we have the first failure with exit 137 on the backfill jobs since the split. |
|
So it looks like the backfill_job tests have some real problems - it failed after 90 minutes. |
|
I have a fix for the Dask Executor, but I'm not sure what is going really on (why it is suddenly failing.) It has But the problem is that |

This is about is about a 20% speed up for short running tasks!
This change doesn't affect the "duration" reported in the TI table, but
does affect the time before the slot is freeded up from the executor -
which does affect overall task/dag throughput.
(All these tests are with the same BashOperator tasks, just running
echo 1.)Before
After
After, including change from #11372
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.