Google Memcached hooks - improve protobuf messages handling #11743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
provider:google
turbaszek
reviewed
Oct 22, 2020
| @@ -572,7 +571,7 @@ def _append_label(instance: cloud_memcache.Instance, key: str, val: str) -> clou | |||
| @staticmethod | |||
| def proto_message_to_dict(message: proto.Message) -> dict: | |||
| """Helper method to parse protobuf message to dictionary.""" | |||
| return json.loads(message.__class__.to_json(message)) | |||
| return message.__class__.to_dict(message) | |||
There was a problem hiding this comment.
Can you add comments in the code explaining why?
There was a problem hiding this comment.
This code has been deleted. Can you look again?
tanjinP
approved these changes
Oct 22, 2020
mik-laj
reviewed
Oct 23, 2020
| @@ -572,7 +571,7 @@ def _append_label(instance: cloud_memcache.Instance, key: str, val: str) -> clou | |||
| @staticmethod | |||
| def proto_message_to_dict(message: proto.Message) -> dict: | |||
| """Helper method to parse protobuf message to dictionary.""" | |||
| return json.loads(message.__class__.to_json(message)) | |||
| return message.__class__.to_dict(message) | |||
There was a problem hiding this comment.
Do we need this method at all? I think we can replace these methods with direct calls.
There was a problem hiding this comment.
I was thinking about it as well. Please check last updates to the PR.
TobKed
force-pushed
the
improve-protobuf-in-google-memcached
branch
from
0fc8add
to
7d1eca7
Compare
mik-laj
approved these changes
Oct 23, 2020
Use to_dict method introduced in proto-plus 1.11.0 instead if operating on json
TobKed
force-pushed
the
improve-protobuf-in-google-memcached
branch
from
7d1eca7
to
6c4d1fe
Compare
turbaszek
approved these changes
Oct 26, 2020
michalmisiewicz
pushed a commit
to michalmisiewicz/airflow
that referenced
this pull request
Oct 30, 2020
szn
pushed a commit
to szn/airflow
that referenced
this pull request
Nov 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use to_dict method introduced in
proto-plus 1.11.0instead if operating on jsonRelated links:
googleapis/python-memcache#19 (comment)
googleapis/proto-plus-python#154
https://proto-plus-python.readthedocs.io/en/latest/messages.html#serialization