Remove loading DagBag multiple times in test_views.py:TestDecorators #11804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were loading DagBag twice, once in `setUpClass` and once in `setUp` (which is called everytime a test in that class is run)
mik-laj
approved these changes
Oct 24, 2020
michalmisiewicz
pushed a commit
to michalmisiewicz/airflow
that referenced
this pull request
Oct 30, 2020
…pache#11804) Previously we were loading DagBag twice, once in `setUpClass` and once in `setUp` (which is called everytime a test in that class is run)
szn
pushed a commit
to szn/airflow
that referenced
this pull request
Nov 1, 2020
…pache#11804) Previously we were loading DagBag twice, once in `setUpClass` and once in `setUp` (which is called everytime a test in that class is run)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were loading DagBag twice, once in
setUpClassand once insetUp(which is called everytime a test in that class is run)This will be enforced by PyUpgrade in #11447 -- which will be merged before 2.0 beta since it can cause conflicts for many PRs since it changes format to f-string that touches a large number of files
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.