Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Python 3 style super classes #11806

Merged
merged 1 commit into from
Oct 24, 2020
Merged

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Oct 24, 2020

example:

super().__init__(label, validators, **kwargs)

instead of

super(DateTimeWithTimezoneField, self).__init__(label, validators, **kwargs)

This will be enforced by PyUpgrade in #11447 -- which will be merged before 2.0 beta since it can cause conflicts for many PRs since it changes format to f-string that touches a large number of files


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

example:

```
super().__init__(label, validators, **kwargs)
```

instead of
```
super(DateTimeWithTimezoneField, self).__init__(label, validators, **kwargs)
```
@kaxil kaxil requested a review from mik-laj October 24, 2020 01:33
@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:webserver Webserver related Issues provider:Apache provider:amazon-aws AWS/Amazon - related issues provider:google Google (including GCP) related issues labels Oct 24, 2020
@kaxil kaxil removed area:API Airflow's REST/HTTP API area:webserver Webserver related Issues provider:amazon-aws AWS/Amazon - related issues provider:Apache provider:google Google (including GCP) related issues labels Oct 24, 2020
@kaxil kaxil requested a review from dimberman October 24, 2020 01:36
@kaxil kaxil merged commit 4830687 into apache:master Oct 24, 2020
@kaxil kaxil deleted the use-py3-super branch October 24, 2020 02:23
michalmisiewicz pushed a commit to michalmisiewicz/airflow that referenced this pull request Oct 30, 2020
example:

```
super().__init__(label, validators, **kwargs)
```

instead of
```
super(DateTimeWithTimezoneField, self).__init__(label, validators, **kwargs)
```
szn pushed a commit to szn/airflow that referenced this pull request Nov 1, 2020
example:

```
super().__init__(label, validators, **kwargs)
```

instead of
```
super(DateTimeWithTimezoneField, self).__init__(label, validators, **kwargs)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants