BigQuery job_id fix for BigQueryInsertJobOperator
#11857
Conversation
boring-cyborg
bot
added
the
provider:google
| @@ -2062,7 +2062,7 @@ def _job_id(self, context): | |||
|
|
|||
| exec_date = context['execution_date'].isoformat() | |||
| job_id = f"airflow_{self.dag_id}_{self.task_id}_{exec_date}_{uniqueness_suffix}" | |||
| return re.sub(r"\:|-|\+\.", "_", job_id) | |||
| return re.sub(r"[:\-+.]", "_", job_id) | |||
There was a problem hiding this comment.
Can you add test for this? It will help us avoid regression. Probably using parametrize will be good idea
There was a problem hiding this comment.
@turbaszek Test added.
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
@nathadfield please rebase due to #11892 and run |
nathadfield
force-pushed
the
bq_jobid_fix
branch
from
60b6363
to
4255844
Compare
|
@turbaszek Thanks! Tests are rerunning again now |
|
Great success! |
Ensures that the
:,-,+and.characters are removed from the string that is built to create a BigQuery jobid.Closes: #11856