-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add template fields renderers to Biguery and Dataproc operators #12067
Add template fields renderers to Biguery and Dataproc operators #12067
Conversation
Airflow has come to a very weird place where providers shows code lines that can never be used due to key functionality is missing in official airflow releases. This resulting in us users saying "wow this is cool! lets try this" only to eventually see that we can't because the core feature wasn't release in any official version. For me it looks like a case where the extension pack of a game is released before the game. |
@RosterIn this will be part of Airflow 2.0. We do not cherrypick every change to 1.10 line, so this change is not unique :) But I understand your disappointment. We need providers to ease migration but we also needs to move on with new features. What would you suggest to do? |
The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed! |
Tried rebasing but missing permissions:
Can you please rebase on latest master please |
@kaxil check this tool: https://github.com/ldez/prm kudos to @mik-laj |
cd50f80
to
62b0463
Compare
That looks good, thanks @turbaszek and @mik-laj |
Related to #11177
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.