Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add template fields renderers to Biguery and Dataproc operators #12067

Merged

Conversation

turbaszek
Copy link
Member

Related to #11177


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the provider:google Google (including GCP) related issues label Nov 3, 2020
@RosterIn
Copy link
Contributor

RosterIn commented Nov 3, 2020

Airflow has come to a very weird place where providers shows code lines that can never be used due to key functionality is missing in official airflow releases.
In that example this renders behavior was added to BaseOperator but was never released.
#11061

This resulting in us users saying "wow this is cool! lets try this" only to eventually see that we can't because the core feature wasn't release in any official version.

For me it looks like a case where the extension pack of a game is released before the game.

@turbaszek
Copy link
Member Author

turbaszek commented Nov 3, 2020

For me it looks like a case where the extension pack of a game is released before the game.

@RosterIn this will be part of Airflow 2.0. We do not cherrypick every change to 1.10 line, so this change is not unique :) But I understand your disappointment. We need providers to ease migration but we also needs to move on with new features. What would you suggest to do?

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed!

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Nov 3, 2020
@kaxil
Copy link
Member

kaxil commented Nov 4, 2020

Tried rebasing but missing permissions:

❯  git push github-desktop-turbaszek HEAD:template-renderes-bq-dataproc -f
remote: Permission to PolideaInternal/airflow.git denied to kaxil.
fatal: unable to access 'https://github.com/PolideaInternal/airflow.git/': The requested URL returned error: 403

Can you please rebase on latest master please

@turbaszek
Copy link
Member Author

Tried rebasing but missing permissions:

❯  git push github-desktop-turbaszek HEAD:template-renderes-bq-dataproc -f
remote: Permission to PolideaInternal/airflow.git denied to kaxil.
fatal: unable to access 'https://github.com/PolideaInternal/airflow.git/': The requested URL returned error: 403

Can you please rebase on latest master please

@kaxil check this tool: https://github.com/ldez/prm kudos to @mik-laj

@turbaszek turbaszek force-pushed the template-renderes-bq-dataproc branch from cd50f80 to 62b0463 Compare November 4, 2020 09:12
@turbaszek turbaszek merged commit 5f5244b into apache:master Nov 4, 2020
@turbaszek turbaszek deleted the template-renderes-bq-dataproc branch November 4, 2020 10:30
@kaxil
Copy link
Member

kaxil commented Nov 4, 2020

@kaxil check this tool: https://github.com/ldez/prm kudos to @mik-laj

That looks good, thanks @turbaszek and @mik-laj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
okay to merge It's ok to merge this PR as it does not require more tests provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants