Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boto calling_format support #1231

Merged
merged 1 commit into from
Apr 1, 2016

Conversation

msumit
Copy link
Contributor

@msumit msumit commented Mar 28, 2016

Boto throws SSL exception for buckets which have dots (.) in their name when used with its default calling format (SubdomainCallingFormat). Adding support to accept other calling formats like 'OrdinaryCallingFormat' and 'VHostCallingFormat'.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.01% when pulling 6482b3b on msumit:boto_calling_format into 0e325d9 on airbnb:master.

@bolkedebruin
Copy link
Contributor

Thanks for the contribution! Please follow these http://chris.beams.io/posts/git-commit/ guidelines for your commit message. It helps creating changelogs and release notes in the future. In this case a more descriptive title (boto is an underlying technology) and and please make it imperative (add vs adding).

And please add some tests so we get increased coverage instead of decreased. Thanks!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 66.328% when pulling 6482b3b7ddd4954e15a11ce6e1abae92f0b77b65 on msumit:boto_calling_format into 0e325d9 on airbnb:master.

@msumit msumit changed the title Adding boto calling_format support Add boto calling_format support Mar 28, 2016
@bolkedebruin
Copy link
Contributor

Please update your commit message (not the PR title) to something like "Add support for calling_format from boto to S3_Hook" and I'll merge. Bonus points if you update the tests and coverage increases. Thanks.

@landscape-bot
Copy link

Code Health
Repository health decreased by 2% when pulling 16f53cc on msumit:boto_calling_format into 0d9c0ac on airbnb:master.

@msumit
Copy link
Contributor Author

msumit commented Apr 1, 2016

Changed the commit message, but couldn't think of a way to test the proposed changes.

@bolkedebruin bolkedebruin merged commit 3198756 into apache:master Apr 1, 2016
@msumit msumit deleted the boto_calling_format branch April 1, 2016 12:17
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 67.023% when pulling 16f53cc on msumit:boto_calling_format into 0d9c0ac on airbnb:master.

@aaur0 aaur0 mentioned this pull request Apr 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants