Don't schedule runs before the DAG's start_date #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage decreased (-0.09%) to 67.11% when pulling c2292911ede580dc36e850ec3892b922ed96ec6e on jlowin:scheduler_start_date into 5ab2567 on airbnb:master. |
|
Nice, are we able to test this? |
jlowin
force-pushed
the
scheduler_start_date
branch
from
c229291 to
0902bea
Compare
|
@bolkedebruin added tests. It won't pass (at least... it shouldn't pass...) until #1290 is in and I rebase (because of some improvements to running Scheduler tests I added there) |
Previously the Scheduler would start scheduling immediately after ANY execution date, irrespective of the DAG's start_date.
jlowin
force-pushed
the
scheduler_start_date
branch
from
0902bea to
cb98181
Compare
|
@bolkedebruin rebased and tests passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #1232