Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prerequisites that new provider package should fulfils #13193

Closed

Conversation

TobKed
Copy link
Contributor

@TobKed TobKed commented Dec 20, 2020

Related to: Add list of prerequisites that new provider package should fulfill

  • directory structure (possibly automated templates or script to create them)
  • usage scenarios for connections in hooks (see discussion in Standardising hooks / connections and adding TTLs #12128)
  • Information about what is required:
  • hooks
    • operators/sensors/transfers
    • unit tests with mocks
    • integration tests if applicable
    • example dags for examples and their use (examples, howtos, system tests)
    • howto guides
  • relation with backport providers.

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

* extras
* provider packages

* ``airflow/providers/dependencies.json``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should happen automatically by pre-commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 0e96670

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment only, but good to go if corrected.

@github-actions
Copy link

The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Dec 21, 2020
@TobKed TobKed marked this pull request as ready for review January 14, 2021 09:18
@TobKed
Copy link
Contributor Author

TobKed commented Jan 14, 2021

Thanks @potiuk! I rebased nad made small update.

@github-actions
Copy link

github-actions bot commented Mar 8, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Mar 8, 2021
@github-actions github-actions bot closed this Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:documentation okay to merge It's ok to merge this PR as it does not require more tests stale Stale PRs per the .github/workflows/stale.yml policy file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants