Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move snowflake limitations to snowflake #13333

Closed
wants to merge 2 commits into from

Conversation

r-richmond
Copy link
Contributor

This PR follows on #13286 by moving the other package limitations that snowflake brings to the snowflake option.

This limits the impacts that snowflake's peculiarities has on the airflow user base to only those who use snowflake.

I have attempted to revert all of the package limitations to as they were before they went in with #12636

@potiuk fyi

Note: Bumped the epoch number as specified in the comment

@potiuk
Copy link
Member

potiuk commented Dec 28, 2020

This does not work, unfortunately. For one, we also have requests limitations in install_requires . If we do not add it there pip install --upgrade --upgrade-strategy eager will produce conflicting requirements.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot merge it unfortunately, because it breaks non-conflicting requirements resolution. We do hope for snowflake to release a new version of their client shortly.

@r-richmond r-richmond closed this Dec 28, 2020
@potiuk
Copy link
Member

potiuk commented Dec 28, 2020

I think i have found a way to achieve it and continue the --eager upgrade working . Stary tuned @r-richmond

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants