Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves documentation regarding providers and custom connections 2 #13410

Merged

Conversation

soltanianalytics
Copy link
Contributor

See #13375 for the first part

The slack discussion went on and I added some more information that might be helpful for others as well. I also fixed a formatting bug that I introduced in the first part.

@potiuk
Copy link
Member

potiuk commented Dec 31, 2020

Good one!

Can you please rebase to latest master + solve conflicts ?

Happy New Year!

@soltanianalytics
Copy link
Contributor Author

Done, thanks!

Happy new year to you, too!

@potiuk
Copy link
Member

potiuk commented Dec 31, 2020

Some spelling errors unfortunately :(

@soltanianalytics
Copy link
Contributor Author

Made some updates - let me know if there is any part you'd like me to go over again :)

@potiuk
Copy link
Member

potiuk commented Jan 1, 2021

Looks great! Merging! Thanks again ! What's next :)?

@potiuk potiuk merged commit 09a2413 into apache:master Jan 1, 2021
@soltanianalytics
Copy link
Contributor Author

Looks great! Merging! Thanks again ! What's next :)?

Thanks! This is next: #13408 ^^

kaxil pushed a commit that referenced this pull request Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants