Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6076] fix dag.cli() KeyError #13647

Merged
merged 6 commits into from
Mar 18, 2021
Merged

[AIRFLOW-6076] fix dag.cli() KeyError #13647

merged 6 commits into from
Mar 18, 2021

Conversation

penggongkui
Copy link
Contributor

@boring-cyborg
Copy link

boring-cyborg bot commented Jan 13, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@mik-laj
Copy link
Member

mik-laj commented Jan 15, 2021

Can you add tests to avoid regression? Besides, thanks a lot for fixing this bug. This is not the first time we've tried to fix this, but I hope we'll have success this time.

@mik-laj
Copy link
Member

mik-laj commented Jan 16, 2021

CI is green, but it still needs tests.

@penggongkui
Copy link
Contributor Author

I have added some test cases

CI is green, but it still needs tests.

@penggongkui
Copy link
Contributor Author

@mik-laj could you please review this PR

how about add this to the 2.0.2 milestone

@mik-laj mik-laj added this to the Airflow 2.0.2 milestone Feb 18, 2021
@ashb ashb merged commit b24a1ba into apache:master Mar 18, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 18, 2021

Awesome work, congrats on your first merged pull request!

ashb pushed a commit that referenced this pull request Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants