Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove permissions to read Configurations for User and Viewer roles #14067

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Feb 4, 2021

Only Admin or Op roles should have permissions to view Configurations.

Previously, Users with User or Viewer role were able to get/view configurations using
the REST API or in the Webserver. From Airflow 2.0.1, only users with Admin or Op role would be able
to get/view Configurations.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Only `Admin` or `Op` roles should have permissions to view Configurations
@kaxil kaxil requested review from ashb and potiuk February 4, 2021 13:49
@boring-cyborg boring-cyborg bot added area:webserver Webserver related Issues kind:documentation labels Feb 4, 2021
@kaxil
Copy link
Member Author

kaxil commented Feb 4, 2021

cc @jhtimmins

@kaxil kaxil added this to the Airflow 2.0.1 milestone Feb 4, 2021
@github-actions
Copy link

github-actions bot commented Feb 4, 2021

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Feb 4, 2021
@kaxil
Copy link
Member Author

kaxil commented Feb 4, 2021

Tests passed: astronomer#1241 -- Merging

@kaxil kaxil merged commit 3909232 into apache:master Feb 4, 2021
@kaxil kaxil deleted the removecan-read-perms-on-confiig branch February 4, 2021 18:39
kaxil added a commit that referenced this pull request Feb 4, 2021
…14067)

Only `Admin` or `Op` roles should have permissions to view Configurations.

Previously, Users with `User` or `Viewer` role were able to get/view configurations using
the REST API or in the Webserver. From Airflow 2.0.1, only users with `Admin` or `Op` role would be able
to get/view Configurations.

(cherry picked from commit 3909232)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues full tests needed We need to run full set of tests for this PR to merge kind:documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants