Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comparison dagTZ with localTZ #14204

Merged
merged 1 commit into from
Feb 15, 2021
Merged

Conversation

millin
Copy link
Contributor

@millin millin commented Feb 12, 2021

Issue is:
image

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Feb 12, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 12, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@ashb
Copy link
Member

ashb commented Feb 12, 2021

Can you give reproduction steps? I didn't think that TZs in momemenum were upercase but the same mixed case.

@millin
Copy link
Contributor Author

millin commented Feb 12, 2021

Hi Ash,
I set default_timezone = Europe/Moscow and default_ui_timezone = Europe/Moscow in config.

dagTZ is converted to upper in line below, but momentjs gives the value not in uppercase - Europe/Moscow

dagTZ = dagTZ.toUpperCase();

so I just changed case of localTZ for correct comparison in below conditions
if (dagTZ !== 'UTC' && dagTZ !== localTZ) {

Copy link
Contributor

@ryanahamilton ryanahamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to reproduce/confirm this.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Feb 12, 2021
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@ashb ashb added pending-response and removed okay to merge It's ok to merge this PR as it does not require more tests labels Feb 12, 2021
@ashb ashb added this to the Airflow 2.0.2 milestone Feb 12, 2021
@ryanahamilton ryanahamilton merged commit fe0ee58 into apache:master Feb 15, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 15, 2021

Awesome work, congrats on your first merged pull request!

@millin millin deleted the millin-patch-1 branch February 15, 2021 16:52
ashb pushed a commit that referenced this pull request Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants