Fix support for long dag_id and task_id in KubernetesExecutor #14703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
provider:cncf-kubernetes
jedcunningham
force-pushed
the
long_task_id
branch
from
891a84b
to
d97c03e
Compare
The key used to remove a task from executor.running is reconstituted from pod annotations, so make sure the full dag_id and task_id are in the annotations.
jedcunningham
force-pushed
the
long_task_id
branch
from
d97c03e
to
d0c5d1b
Compare
ashb
approved these changes
Mar 26, 2021
ashb
pushed a commit
that referenced
this pull request
Mar 26, 2021
The key used to remove a task from executor.running is reconstituted from pod annotations, so make sure the full dag_id and task_id are in the annotations. (cherry picked from commit b5e7ada)
ashb
pushed a commit
that referenced
this pull request
Apr 15, 2021
The key used to remove a task from executor.running is reconstituted from pod annotations, so make sure the full dag_id and task_id are in the annotations. (cherry picked from commit b5e7ada)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #14326
The key used to remove a task from executor.running is reconstituted
from pod annotations, so make sure the full dag_id and task_id are in
the annotations.