-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(smart_sensor): runtime and unbound var errors #14774
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shivanshs9 Can you rebase your PR on Main please and fix the conflicts |
Signed-off-by: Shivansh Saini <shivanshs9@gmail.com>
9a16412
to
cfd2345
Compare
@kaxil I rebased the PR and apparently the RuntimeError is fixed in another PR - #14920, explained in this comment. |
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Signed-off-by: Shivansh Saini <shivanshs9@gmail.com> Closes apache#14770
Closes #14770
Fixes various runtime errors in smart sensor:
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.