Compare string values, not if strings are the same object #14942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedcunningham
requested review from
ashb,
kaxil,
turbaszek and
XD-DENG
as code owners
boring-cyborg
bot
added
provider:cncf-kubernetes
kaxil
approved these changes
Mar 22, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Mar 29, 2021
I found this when investigating why the delete_worker_pods_on_failure flag wasn't working. The feature has sufficient test coverage, but doesn't fail simply because the strings have the same id when running in the test suite, which is exactly what happens in practice. flake8/pylint also don't seem to raise their respective failures unless one side it literally a literal string, even though typing is applied 🤷♂️. I fixed 2 other occurrences I found while I was at it. (cherry picked from commit 6d30464)
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 1, 2021
I found this when investigating why the delete_worker_pods_on_failure flag wasn't working. The feature has sufficient test coverage, but doesn't fail simply because the strings have the same id when running in the test suite, which is exactly what happens in practice. flake8/pylint also don't seem to raise their respective failures unless one side it literally a literal string, even though typing is applied 🤷♂️. I fixed 2 other occurrences I found while I was at it. (cherry picked from commit 6d30464)
ashb
pushed a commit
that referenced
this pull request
Apr 1, 2021
I found this when investigating why the delete_worker_pods_on_failure flag wasn't working. The feature has sufficient test coverage, but doesn't fail simply because the strings have the same id when running in the test suite, which is exactly what happens in practice. flake8/pylint also don't seem to raise their respective failures unless one side it literally a literal string, even though typing is applied 🤷♂️. I fixed 2 other occurrences I found while I was at it. (cherry picked from commit 6d30464)
ashb
pushed a commit
that referenced
this pull request
Apr 15, 2021
I found this when investigating why the delete_worker_pods_on_failure flag wasn't working. The feature has sufficient test coverage, but doesn't fail simply because the strings have the same id when running in the test suite, which is exactly what happens in practice. flake8/pylint also don't seem to raise their respective failures unless one side it literally a literal string, even though typing is applied 🤷♂️. I fixed 2 other occurrences I found while I was at it. (cherry picked from commit 6d30464)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this when investigating why the
delete_worker_pods_on_failureflag wasn't working. The feature has sufficient test coverage, but doesn't fail simply because the strings have the same id when running in the test suite, which is exactly what happens in practice.flake8/pylint also don't seem to raise their respective failures unless one side it literally a literal string, even though typing is applied 🤷♂️.
I fixed 2 other occurrences I found while I was at it.