Fix too specific parsing of False in LegacyUIDeprecated
#14967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhtimmins
previously requested changes
Mar 24, 2021
Added more Unittest for possible False values
|
Added some False options in the unittest. No idea why the CI Builds are failing :) . |
|
@jhtimmins can you have another look? |
ashb
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of two issues mentioned in #13287 . The issue is trivial one: only
falsecase sensitive was taken into account, however, the Airflow config allows many more options for the boolean False.This fix is basically a replacement of the case sensitive check for
falseby the same logicgetboolean()uses. Usinggetboolean()itself seems not to be a good solution, since it throws an Exception if there is a blank value in the field.