Prevent clickable bad links on disabled pagination #15074
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10200
The " first page" and " last page" links in the DAGs pagination has a "disabled" class added to them when they are disabled. This yields a "not allowed" cursor on hover, but the anchors yield a still clickable malformed url in the
href
(e.g.page=-1
) as described in #10200.This update simply returns
javascript:void(0)
if the links are disabled the same way that the "previous page" and "next page" buttons already handle it.