Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent clickable bad links on disabled pagination #15074

Merged

Conversation

ryanahamilton
Copy link
Contributor

Resolves #10200

The " first page" and " last page" links in the DAGs pagination has a "disabled" class added to them when they are disabled. This yields a "not allowed" cursor on hover, but the anchors yield a still clickable malformed url in the href (e.g. page=-1) as described in #10200.

This update simply returns javascript:void(0) if the links are disabled the same way that the "previous page" and "next page" buttons already handle it.

@ryanahamilton ryanahamilton requested a review from ashb March 29, 2021 18:28
@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Mar 29, 2021
@ryanahamilton ryanahamilton added the area:UI Related to UI/UX. For Frontend Developers. label Mar 29, 2021
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Mar 29, 2021
@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@ryanahamilton ryanahamilton merged commit 57388ef into apache:master Mar 29, 2021
@ryanahamilton ryanahamilton deleted the fix/disabled_pagination_links branch March 29, 2021 21:13
@ashb ashb added this to the Airflow 2.1 milestone Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WEB UI, last page button does not work when all dags are in not active state
2 participants