Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'conf' from search_columns in DagRun View #15099

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

XD-DENG
Copy link
Member

@XD-DENG XD-DENG commented Mar 30, 2021

closes: #14374

i.e. to not support filter by Conf column.

Detailed analysis behind this change is in #14374 (comment) and #14374 (comment) .


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@XD-DENG XD-DENG added the area:webserver Webserver related Issues label Mar 30, 2021
@XD-DENG XD-DENG added this to the Airflow 2.0.2 milestone Mar 30, 2021
@XD-DENG XD-DENG requested review from kaxil and mik-laj March 30, 2021 18:09
i.e. to not support filtering by 'conf' column.

It cannot be supported because FAB uses ILIKE under the hood,
which is not supported by 'bytea' type in Postgres or 'BLOB' in SQLite.

Closes issue apache#14374
@XD-DENG XD-DENG added the type:bug-fix Changelog: Bug Fixes label Mar 30, 2021
@XD-DENG XD-DENG merged commit 3585b3c into apache:master Mar 30, 2021
@XD-DENG XD-DENG deleted the issue-14374 branch March 30, 2021 19:10
ashb pushed a commit that referenced this pull request Apr 1, 2021
i.e. to not support filtering by 'conf' column in DagRun View.

This cannot be supported because FAB uses ILIKE under the hood,
which is not supported by 'bytea' type in Postgres or 'BLOB' in SQLite.

Closes issue #14374

(cherry picked from commit 3585b3c)
ashb pushed a commit that referenced this pull request Apr 15, 2021
i.e. to not support filtering by 'conf' column in DagRun View.

This cannot be supported because FAB uses ILIKE under the hood,
which is not supported by 'bytea' type in Postgres or 'BLOB' in SQLite.

Closes issue #14374

(cherry picked from commit 3585b3c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search in "DAG Runs" crashed with "Conf" filter
3 participants