Remove duplicate call to sync_metadata inside DagFileProcessorManager #15121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`_process_message` already calls sync_metadata if it's a DagParsingStat, so there's no need to call it again. This isn't expensive, but no point doing it I've also added a runtime check to ensure this function is only used in sync mode, which makes the purpose/logic used in this function clearer.
boring-cyborg
bot
added
the
area:Scheduler
XD-DENG
approved these changes
Mar 31, 2021
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 1, 2021
…apache#15121) `_process_message` already calls sync_metadata if it's a DagParsingStat, so there's no need to call it again. This isn't expensive, but no point doing it I've also added a runtime check to ensure this function is only used in sync mode, which makes the purpose/logic used in this function clearer. (cherry picked from commit 116a8a0)
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 12, 2021
…apache#15121) `_process_message` already calls sync_metadata if it's a DagParsingStat, so there's no need to call it again. This isn't expensive, but no point doing it I've also added a runtime check to ensure this function is only used in sync mode, which makes the purpose/logic used in this function clearer. (cherry picked from commit 116a8a0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_process_messagealready calls sync_metadata if it's a DagParsingStat,so there's no need to call it again. This isn't expensive, but no point
doing it
I've also added a runtime check to ensure this function is only used in
sync mode, which makes the purpose/logic used in this function clearer.