A bunch of template_fields_renderers additions #15130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly SQL fields and Python options.
This is technically wrong since the command here is interpreted in either cmd.exe or Powershell syntax. But I feel they are sufficiently close to Bash for UI purposes.
The lexer is called DjangoLexer, but Pygments documentation says it's good enough for Jinja2 templates.
uranusjr
requested review from
ashb,
potiuk,
ryanahamilton and
turbaszek
as code owners
boring-cyborg
bot
added
area:providers
area:webserver
ashb
reviewed
Apr 1, 2021
ashb
approved these changes
Apr 1, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
kaxil
approved these changes
Apr 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #11177. Mostly SQL fields and Python options. Two notable execeptions:
WinRMOperator.commandis marked asbasheven it’s technically not. cmd.exe and Powershell are close enough for syntax highlighting purposes IMO.powershell.jinjarenderer is implemented. The Pygment lexer is calledDjangoLexer, but Pygments suggets rendering Jinja2 with it.Fix #14543.
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.