Queue tasks with higher priority and earlier execution_date first.

[ginevragaudioso]

See issue #15171.

I tested the query on our airflow instance and it correctly sorts the results.

closes: #15171
related: #15171

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

• Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@airflow.apache.org
  Slack: https://s.apache.org/airflow-slack

[github-actions]

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

[github-actions]

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

[github-actions]

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

[kaxil]

Please rebase on latest master, that should fix the failing error

[kaxil]

I just pushed, should work now

[ginevragaudioso]

Thanks @kaxil for fixing the build. Anything else I should do here?

[kaxil]

cc @ashb

[ginevragaudioso]

@kaxil @ashb would it be possible to have this fix go in 2.0.2? Seems like an easy fix that solves an actual issue, but I don't know what's in the roadmap.

[ashb]

@ginevragaudioso Sorry, was too late (even yesterday) as the RC was already being voted upon.

[github-actions]

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

[ashb]

The tests need expanding -- the TIs it create have the same priority and execution_date, so we aren't actually asserting that the TIs are sorted correctly.

[ginevragaudioso]

The tests need expanding -- the TIs it create have the same priority and execution_date, so we aren't actually asserting that the TIs are sorted correctly.

The TIs created do not have the same execution date, unless I am missing something.

        dr1 = dag_1.create_dagrun(
             run_type=DagRunType.SCHEDULED,
             execution_date=DEFAULT_DATE + timedelta(hours=1),
             state=State.RUNNING,
         )
         dr2 = dag_2.create_dagrun(
             run_type=DagRunType.SCHEDULED,
             execution_date=DEFAULT_DATE,
             state=State.RUNNING,
         )

        tis = [
             TaskInstance(dag1_task, dr1.execution_date),   # THIS IS DEFAULT_DATE + timedelta(hours=1)  (later)
             TaskInstance(dag2_task, dr2.execution_date),   # THIS IS DEFAULT_DATE                       (earlier)
         ]

So the test is testing that we pick the one with the earliest execution date even if it is alphabetically later (which is exactly the bug being fixed).

[uranusjr]

I think what Ash meant was the currently available tests either has the same execution date or the same priority, and need to be extended to cover more combination of values.

[ginevragaudioso]

The tests need expanding -- the TIs it create have the same priority and execution_date, so we aren't actually asserting that the TIs are sorted correctly.

@ashb thanks for the feedback, I added two more tests, one for priority and one for both.

[jhtimmins]

@ashb bumping you to review the updated tests you requested here #15210 (review)

[ashb]

Small changes that I can do via suggestion.

[boring-cyborg]

Awesome work, congrats on your first merged pull request!

[kaxil]

Well done @ginevragaudioso 👏