Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: allow hiding of all edges in Graph when highlighting states #15281

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

ryanahamilton
Copy link
Contributor

Fixes a small regression introduced by #15257.

Fades out the edges (lines between tasks) when hovering or clicking a state in the legend.

Before After
Screen Recording 2021-04-08 at 11 47 23 AM Screen Recording 2021-04-08 at 11 46 03 AM

@ryanahamilton ryanahamilton added the area:UI Related to UI/UX. For Frontend Developers. label Apr 8, 2021
@ryanahamilton ryanahamilton requested a review from ashb as a code owner April 8, 2021 15:48
@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Apr 8, 2021
Copy link
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

@github-actions
Copy link

github-actions bot commented Apr 8, 2021

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Apr 8, 2021
@ryanahamilton ryanahamilton merged commit 1d635ef into apache:master Apr 8, 2021
@ryanahamilton ryanahamilton deleted the fix_state_highlight branch April 8, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants