Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speeds up Docker build process by combining RUN and ENV commands #15438

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Apr 19, 2021

The Dockerfile is more "packed" and certain ARG/ENVs are in separate
parts of it but we save minutes in certain scenarios when the images
are built (especially when they are built in parallell, the
difference might be significant)

This change also removes some of the old, already unused CASS_DRIVER
ARGS and ENVS. They are not needed any more as cassandra drivers do
not require CPYTHON compilation any more.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@github-actions
Copy link

The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the workflow link to check the reason.

@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Apr 20, 2021
@potiuk potiuk force-pushed the speed-up-docker-building-process branch from 19a28fe to dbcca85 Compare April 20, 2021 09:20
@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@potiuk potiuk force-pushed the speed-up-docker-building-process branch 2 times, most recently from 80c9805 to e652c80 Compare April 20, 2021 13:22
@github-actions
Copy link

The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the workflow link to check the reason.

@potiuk potiuk closed this Apr 20, 2021
@potiuk potiuk reopened this Apr 20, 2021
@potiuk
Copy link
Member Author

potiuk commented Apr 20, 2021

Triggering re-build

The Dockerfile is more "packed" and certain ARG/ENVs are in separate
parts of it but we save minutes in certain scenarios when the images
are built (especially when they are built in parallell, the
difference might be significant)

This change also removes some of the old, already unused CASS_DRIVER
ARGS and ENVS. They are not needed any more as cassandra drivers do
not require CPYTHON compilation any more.
@potiuk potiuk force-pushed the speed-up-docker-building-process branch from e652c80 to 76269ce Compare April 23, 2021 13:08
@potiuk potiuk merged commit 043a88d into apache:master Apr 23, 2021
@potiuk potiuk deleted the speed-up-docker-building-process branch April 23, 2021 14:08
@potiuk potiuk mentioned this pull request Apr 27, 2021
potiuk added a commit to potiuk/airflow that referenced this pull request May 6, 2021
…che#15438)

The Dockerfile is more "packed" and certain ARG/ENVs are in separate
parts of it but we save minutes in certain scenarios when the images
are built (especially when they are built in parallell, the
difference might be significant)

This change also removes some of the old, already unused CASS_DRIVER
ARGS and ENVS. They are not needed any more as cassandra drivers do
not require CPYTHON compilation any more.

(cherry picked from commit 043a88d)
@potiuk potiuk added this to the Airflow 2.0.3 milestone May 9, 2021
@ashb ashb modified the milestones: Airflow 2.0.3, Airflow 2.1 May 18, 2021
@potiuk potiuk restored the speed-up-docker-building-process branch April 26, 2022 20:49
@potiuk potiuk deleted the speed-up-docker-building-process branch July 29, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools full tests needed We need to run full set of tests for this PR to merge kind:documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants