-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes constraint generation for pypi providers #15470
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constraints generated from PyPI version of providers, missed core requirements of Airflow, therefore the constraints were not consistent with setup.py core requirements. Fixes: apache#15463
ashb
approved these changes
Apr 21, 2021
uranusjr
reviewed
Apr 21, 2021
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 26, 2021
* Fixes constraint generation for pypi providers The constraints generated from PyPI version of providers, missed core requirements of Airflow, therefore the constraints were not consistent with setup.py core requirements. Fixes: apache#15463 (cherry picked from commit 5da74f6)
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
May 6, 2021
* Fixes constraint generation for pypi providers The constraints generated from PyPI version of providers, missed core requirements of Airflow, therefore the constraints were not consistent with setup.py core requirements. Fixes: apache#15463 (cherry picked from commit 5da74f6)
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
May 6, 2021
* Fixes constraint generation for pypi providers The constraints generated from PyPI version of providers, missed core requirements of Airflow, therefore the constraints were not consistent with setup.py core requirements. Fixes: apache#15463 (cherry picked from commit 5da74f6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constraints generated from PyPI version of providers, missed
core requirements of Airflow, therefore the constraints were not
consistent with setup.py core requirements.
Fixes: #15463
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.