Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes constraint generation for pypi providers #15470

Merged
merged 2 commits into from
Apr 21, 2021

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Apr 21, 2021

The constraints generated from PyPI version of providers, missed
core requirements of Airflow, therefore the constraints were not
consistent with setup.py core requirements.

Fixes: #15463


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

The constraints generated from PyPI version of providers, missed
core requirements of Airflow, therefore the constraints were not
consistent with setup.py core requirements.

Fixes: apache#15463
@potiuk potiuk requested a review from ashb as a code owner April 21, 2021 11:26
@potiuk potiuk requested a review from kaxil April 21, 2021 11:26
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Apr 21, 2021
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
@potiuk potiuk merged commit 5da74f6 into apache:master Apr 21, 2021
@potiuk potiuk deleted the fix-constraints-generation branch April 21, 2021 12:06
kaxil pushed a commit to astronomer/airflow that referenced this pull request Apr 26, 2021
* Fixes constraint generation for pypi providers

The constraints generated from PyPI version of providers, missed
core requirements of Airflow, therefore the constraints were not
consistent with setup.py core requirements.

Fixes: apache#15463
(cherry picked from commit 5da74f6)
potiuk added a commit to potiuk/airflow that referenced this pull request May 6, 2021
* Fixes constraint generation for pypi providers

The constraints generated from PyPI version of providers, missed
core requirements of Airflow, therefore the constraints were not
consistent with setup.py core requirements.

Fixes: apache#15463
(cherry picked from commit 5da74f6)
potiuk added a commit to potiuk/airflow that referenced this pull request May 6, 2021
* Fixes constraint generation for pypi providers

The constraints generated from PyPI version of providers, missed
core requirements of Airflow, therefore the constraints were not
consistent with setup.py core requirements.

Fixes: apache#15463
(cherry picked from commit 5da74f6)
@potiuk potiuk added this to the Airflow 2.0.3 milestone May 9, 2021
@ashb ashb modified the milestones: Airflow 2.0.3, Airflow 2.1 May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency between the setup.py and the constraints file
3 participants