Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve logs with Scheduler when using Local or Sequential Executor #15557

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Apr 28, 2021

Currently, the serve_logs endpoint only exists on Celery workers. This
means if someone launches Airflow with the LocalExecutor and wants to
grab the logs from the scheduler, there is no way to move that to the
webserver if it is on a different pod/machine.

This commit makes the scheduler automatically serves logs when using
LocalExecutor or SequentialExecutor. However, it means for
Airflow <= 2.0.2, the Helm Chart won't serve logs.

closes #15070
closes #13331
closes #15071
closes #14222


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Currently, the `serve_logs` endpoint only exists on Celery workers. This
means if someone launches Airflow with the `LocalExecutor` and wants to
grab the logs from the scheduler, there is no way to move that to the
webserver if it is on a different pod/machine.

This commit makes the scheduler automatically serves logs when using
`LocalExecutor` or `SequentialExecutor`. However, it means for
Airflow <= 2.0.2, the Helm Chart won't serve logs.

closes apache#15070
closes apache#13331
closes apache#15071
closes apache#14222
@kaxil
Copy link
Member Author

kaxil commented Apr 28, 2021

Alternative approach: #15556 where Helm Chart will work pre and post 2.0.3

@kaxil kaxil requested review from mik-laj and ashb April 28, 2021 01:46
@kaxil kaxil marked this pull request as ready for review April 28, 2021 01:46
@kaxil kaxil requested a review from dimberman as a code owner April 28, 2021 01:46
@kaxil kaxil merged commit 414bb20 into apache:master Apr 29, 2021
@kaxil kaxil deleted the scheduler-serve-logs branch April 29, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:CLI area:helm-chart Airflow Helm Chart
Projects
None yet
3 participants