Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce false-positives when detecting SQLite usage #15716

Merged
merged 1 commit into from
May 7, 2021

Conversation

SamWheating
Copy link
Contributor

While working on a different fix I noticed that we were checking for sqlite like so:

if 'sqlite' in conf.get('core', 'sql_alchemy_conn')

While I know that its unlikely, this could incorrectly detect sqlite if the string appears anywhere in the sqlalchemy connection string. For example, a postrges connection to a database called not-sqlite:

postgresql://user:pass@localhost:5432/not-sqlite

Anyways, using .startswith('sqlite') should be a little more reliable here, as the dialect is always specified at the very beginning of an sqlalchemy connection string.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the area:Scheduler including HA (high availability) scheduler label May 7, 2021
@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label May 7, 2021
@github-actions
Copy link

github-actions bot commented May 7, 2021

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@ashb ashb merged commit e81ec7c into apache:master May 7, 2021
potiuk pushed a commit that referenced this pull request May 8, 2021
@potiuk potiuk added this to the Airflow 2.0.3 milestone May 9, 2021
@ashb ashb modified the milestones: Airflow 2.0.3, Airflow 2.1 May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Scheduler including HA (high availability) scheduler full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants