-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error earlier if virtualenv is not installed and DAG has a PythonVirtualenvOperator #15788
Error earlier if virtualenv is not installed and DAG has a PythonVirtualenvOperator #15788
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
Technically |
Hey @MatrixManAtYrService - can you please rebase it to the latest |
cb006ae
to
dee29d2
Compare
dee29d2
to
7bc1336
Compare
Oops, must've overlooked the earlier notification.
|
Temporary errors only :) |
While trying to use
@task.virtualenv
I got this error:It was helpful enough that I was able to guess that
pip install virtualenv
would fix things for me, but:FileNotFoundError
made me doubt that it was a packaging issueThis PR checks if virtualenv is importable at init time and throws a more helpful exception.
I'm interested to know if there's a better way to handle things like this, but this is at least better than how it was.