Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-239] Fix tests indentation #1591

Closed
wants to merge 1 commit into from
Closed

[AIRFLOW-239] Fix tests indentation #1591

wants to merge 1 commit into from

Conversation

ldct
Copy link
Contributor

@ldct ldct commented Jun 14, 2016

Dear Airflow Maintainers,

Please accept this PR that addresses the following issues:

@codecov-io
Copy link

codecov-io commented Jun 14, 2016

Current coverage is 68.02%

Merging #1591 into master will decrease coverage by 0.01%

@@             master      #1591   diff @@
==========================================
  Files           116        116          
  Lines          8310       8310          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           5654       5653     -1   
- Misses         2656       2657     +1   
  Partials          0          0          

Powered by Codecov. Last updated by 8aa7160...8c92ace

@plypaul
Copy link
Contributor

plypaul commented Jun 14, 2016

Looks good, but the commit message seems to have been messed up.

@ldct ldct changed the title Deindent tests - previously, due to indentation these methods were tr… [AIRFLOW-1591] Deindent tests Jun 14, 2016
@ldct ldct changed the title [AIRFLOW-1591] Deindent tests [AIRFLOW-231] Deindent tests Jun 14, 2016
@ldct ldct changed the title [AIRFLOW-231] Deindent tests [AIRFLOW-239] Deindent tests Jun 14, 2016
@ldct ldct changed the title [AIRFLOW-239] Deindent tests [AIRFLOW-239] Indent tests Jun 15, 2016
@ldct ldct changed the title [AIRFLOW-239] Indent tests [AIRFLOW-239] Fix tests indentation Jun 15, 2016
Fix indentation - previously, due to indentation some methods were
treated as internal functions of test_presto_to_mysql and not
collected by nosetests.
@plypaul
Copy link
Contributor

plypaul commented Jun 15, 2016

@aoen @mistercrunch ^

@asfgit asfgit closed this in 01952b3 Jun 15, 2016
@ldct ldct deleted the deindent-tests branch July 14, 2016 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants