Handle special characters in password sfor Helm Chart #16004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 23, 2021
|
I found a solution. Updated and ready for review. |
mik-laj
changed the title
potiuk
approved these changes
May 23, 2021
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #16000
I've tried to fix this bug, but I'm afraid the Helm rendering engine is missing the necessary function. Username and Password should be percent-encoded, but Helm doesn't have such a function that does it, but there's an open ticket for it. https://github.com/Masterminds/sprig/issues/248 We also cannot expect users to enter an encoded password, because we use these variables in two contexts, and sometimes it is needed encrypted and raw to others. https://github.com/apache/airflow/blob/b66b54c83cb2efa274ba8040ce22ae719defbe75/chart/templates/_helpers.yaml#L344I build a new URI using
urlJoinandurlqueryfunction, so all characters should be handled correctly.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.